fix(interopgen): use InteropOffset when setting Interop genesis flags#20148
Merged
fix(interopgen): use InteropOffset when setting Interop genesis flags#20148
InteropOffset when setting Interop genesis flags#20148Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #20148 +/- ##
===========================================
+ Coverage 11.5% 66.3% +54.7%
===========================================
Files 668 55 -613
Lines 72125 4035 -68090
===========================================
- Hits 8332 2677 -5655
+ Misses 63649 1214 -62435
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
maurelian
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenesisL2was enablingUseInteropandOptimismPortalInteropFlagbased entirely on whether the world had more than one chain. This causedL2Genesis.s.solto reject the configuration withL2Genesis_InvalidInteropConfigwheneverInteropOffset > 0, because the fork number at genesis would be pre-Interop while both flags were set.Changes
multichainDepSet && interopOffset == 0. Interop will only be enabled at genesis if it's actually scheduled to activate.Closes #20079